Skip to content

Set the default `n_chains_per_rank` for exact samplers to 1

Vicentini Filippo requested to merge github/fork/wdphy16/sampler_api_2 into master

Created by: wdphy16

The second PR in the #1013 series.

API changes:

  • The default value of n_chains_per_rank in Sampler and exact samplers is changed to 1, and specifying n_chains or n_chains_per_rank when constructing them is deprecated. Please change chain_length when calling sample. For MetropolisSampler, the default value n_chains = 16 (across all ranks) is unchanged.

In test/sampler/test_sampler.py::test_exact_sampler I added the test for the default value of n_chains or n_chains_per_rank, and I removed all specified n_chains when constructing the samplers.

Merge request reports