Skip to content

Deprecate sampler module functions

Vicentini Filippo requested to merge github/fork/wdphy16/sampler_api_2 into master

Created by: wdphy16

The third PR in the #1013 series. Those module functions don't really serve a purpose today and will be deprecated.

API changes:

  • The method Sampler.samples is added to return a generator of samples. The module functions nk.sampler.sampler_state, reset, sample, samples, and sample_next are deprecated in favor of the corresponding class methods. #1025

I moved the logics from the module functions to the class methods, and replaced the module functions in the tests.

Merge request reports