Skip to content

Breaking: `reset_chain`->`reset_chains`, `acceptance_ratio`->`acceptance`

Vicentini Filippo requested to merge breakingstuff into master

Created by: PhilipVinc

From feedback from a few users:

  • reset_chain was singular, while everything else was plural, so let's be consistent.
  • SampelrState.acceptance_ratio returned the percentage (not a ratio). Also in much code that automatically adjust number of samples you need a ratio not a percentage. So fixes the bug and rename the variable to acceptance.

There are deprecation warnings in case anybody was using this stuff.

Merge request reports