Skip to content

hilbert.random_state: missing deprecation warning

Vicentini Filippo requested to merge pv/warn into master

Created by: PhilipVinc

Since we abstain from releasing 3.0 we are carrying tons of deprecations in our code. In particular hilbert.random_State supports both the old and the new syntax.

The new syntax requires the first argument to be a sax-compatible PRNGKey, otherwise the old is always assumed.

The old syntax does not use the new random state generation mechanism (and has bugs when constraints are considered), so users can find surprising that nk.hilbert.random_state() (legacy) generates states different from what the samplers obtains.

The legacy syntax was not printing a deprecation warning so it was impossible to tell them apart. This PR adds such a deprecation warning.

Merge request reports