Skip to content

Apply flakehell to netket

Vicentini Filippo requested to merge flake8 into master

Created by: PhilipVinc

This adds flakehell as a dev tool to netket and solves most issues revealed by it. It's a rebranded version of pyflakes and pylint that makes it easy to disable specific errors and add others.

It uncovered 3 few bugs, like wrong assertions raised that don't exist, inexistant arguments... those are addressed.

There is still a bug that it has uncovered that is not solved : JsonLog in append mode will overwrite the file. I will address this in a separate PR.

most Issues were solved automatically (removed extra imports a bit everywhere) a few formatting issues and then a bunch where addressed manually.

To run flakehell manually you just need to do flakehell lint netket.

Merge request reports