Skip to content
Snippets Groups Projects
Unverified Commit 8f8b0a2e authored by Filippo Vicentini's avatar Filippo Vicentini Committed by GitHub
Browse files

Rename tolerance arguments of TDVPSchmitt to something more sensible (#1523)

The tolerance arguments of
{class}`~netket.experimental.dynamics.TDVPSchmitt` have all been renamed
to more understandable quantities without inspecting the source code.

In particular,  
- `num_tol` has been renamed to `rcond`, because it does the same thing
as `rcond` does in `svd`.
- `svd_tol` to `rcond_smooth` , to be consistent with the same argument
that has been introduced in `solvers.pinv_smooth` from #1518
- `noise_tol` to `noise_atol`, because it's an absolute tolerance, and
in principle we could think to add a relative tolerance as well...

This is a breaking change but this stuff is experimental.
parent 9e353847
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment