Skip to content
Snippets Groups Projects

Support mixed real/imaginary parameters with QGTJacobianDense

Merged Vicentini Filippo requested to merge pc/fix-qgtdense into master

Created by: PhilipVinc

Before this PR, the matmul and solve interface of QGTJacobianDense is not consistent with the order of tree_to_Real and tree_ravel used by nk.jax.jacobian leading to wrong results if the pytree is non homogeneous (and maybe in other cases).

This PR fixes those inconsistencies, and now QGTJacobianDense can support pytrees with both real and complex parameters of the same (32/64) bit precision.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
Please register or sign in to reply
Loading