Skip to content

Rename tolerance arguments of TDVPSchmitt to something more sensible

Vicentini Filippo requested to merge github/fork/PhilipVinc/pv/schmitt into master

Created by: PhilipVinc

The tolerance arguments of {class}~netket.experimental.dynamics.TDVPSchmitt have all been renamed to more understandable quantities without inspecting the source code.

In particular,

  • num_tol has been renamed to rcond, because it does the same thing as rcond does in svd.
  • svd_tol to rcond_smooth , to be consistent with the same argument that has been introduced in solvers.pinv_smooth from #1518
  • noise_tol to noise_atol, because it's an absolute tolerance, and in principle we could think to add a relative tolerance as well...

This is a breaking change but this stuff is experimental.

@jwnys your opinion on this change?

Merge request reports